Skip to content

fix docs links #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 1, 2023
Merged

fix docs links #942

merged 5 commits into from
Mar 1, 2023

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Feb 27, 2023 •
edited
Loading

  • Fix spelling error in readme
  • Fix missing href in readme
  • Change docs links to reactpy.dev
  • Run formatter on readme

Checklist

Please update this checklist as you complete each item:

  • Tests have been included for all bug fixes or added functionality.
  • The changelog.rst has been updated with any significant changes.
  • GitHub Issues which may be closed by this Pull Request have been linked.

@rmorshea
Copy link
Collaborator

rmorshea commented Mar 1, 2023

Docs are actually available at reactpy.dev now

@Archmonger
Copy link
Contributor Author

Archmonger commented Mar 1, 2023 •
edited
Loading

@rmorshea I can't request review in the reactive-python org.

This PR uses reactpy.dev

@Archmonger
Copy link
Contributor Author

Archmonger commented Mar 1, 2023 •
edited
Loading

Also, given that we deprecated module_from_template, it might be a good idea to throw away the flaky VictoryContainer tests.

@rmorshea rmorshea merged commit 83d6c28 into reactive-python:main Mar 1, 2023
@Archmonger Archmonger deleted the fix-docs-links branch March 1, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmorshea rmorshea rmorshea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Archmonger @rmorshea